search

wbond / sublime_terminal

Launch terminals from the current file or the root project folder
https://packagecontrol.io/packages/Terminal
MIT License
597 stars 117 forks source link

Support opening multiple terminal types (#16 and #197) #206

Closed PinataMostGrim closed 5 years ago

PinataMostGrim commented 5 years ago

Adds support for defining and opening multiple terminal types. If a terminal parameter isn't passed into the command, it will look for the default 'terminal'.

Resolves #16 and resolves #197.

Examples

Optional terminal definition (in Terminal.sublime-settings or OS specific settings):

"git-bash": "C:\\Program Files\\Git\\git-bash.exe",

Additional Terminal: Open command (in Default.sublime-commands):

{
    "caption":"Terminal: Open Git Bash",
    "command":"open_terminal",
    "args": {
        "terminal": "git-bash",
        "parameters": []
    }
}
twolfson commented 5 years ago

Sorry for the slow reply. I'm on my way back from a long vacation. I'll review this within the next 2 weeks

On Sun, Apr 28, 2019, 3:53 AM Aaron notifications@github.com wrote:

Adds support for defining and opening multiple terminal types. If a terminal parameter isn't passed into the command, it will look for the default 'terminal'.

Resolves #16 https://github.com/wbond/sublime_terminal/issues/16 and resolves #197 https://github.com/wbond/sublime_terminal/issues/197. Examples

Optional terminal definition (in Terminal.sublime-settings or OS specific settings):

"git-bash": "C:\Program Files\Git\git-bash.exe",

Additional Terminal: Open command (in Default.sublime-commands):

{ "caption":"Terminal: Open Git Bash", "command":"open_terminal", "args": { "terminal": "git-bash", "parameters": [] } }

You can view, comment on, or merge this pull request online at:

https://github.com/wbond/sublime_terminal/pull/206 Commit Summary

  • Support opening multiple terminal types (#16 and #197)

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wbond/sublime_terminal/pull/206, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG4KWBYF766EG5JJ6EWHCDPST7TNANCNFSM4HI5MWJQ .

PinataMostGrim commented 5 years ago

No worries! :+1:

twolfson commented 5 years ago

This has been merged/released in 1.20.0. Thanks again for the PR!

PinataMostGrim commented 5 years ago

No problem! Thanks for your comments in the resolved issues. They helped me figure out where to start.