search

wbond / sublime_terminal

Launch terminals from the current file or the root project folder
https://packagecontrol.io/packages/Terminal
MIT License
597 stars 117 forks source link

Update iTerm2-v3.sh #210

Closed kitsguru closed 5 years ago

kitsguru commented 5 years ago

fix #208 iterm2 change directory on first call

twolfson commented 5 years ago

Looks good to me though I'd like to undo a lot of the unnecessary whitespace changes. I don't have much time to land this immediately. I will land it by the end of the month

kitsguru commented 5 years ago

I was looking for an editorconfig file, but used my default.

On Sun, Sep 8, 2019 at 12:31 AM Todd Wolfson notifications@github.com wrote:

Looks good to me though I'd like to undo a lot of the unnecessary whitespace changes. I don't have much time to land this immediately. I will land it by the end of the month

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wbond/sublime_terminal/pull/210?email_source=notifications&email_token=AAKSR27NJQTGT6D4MVQABGLQIQTSVA5CNFSM4IS7EZRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FDQNA#issuecomment-529152052, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKSR2Y2LQDI42DAZQUAG5LQIQTSVANCNFSM4IS7EZRA .

twolfson commented 5 years ago

Thanks for all your work on this! This has been landed and released in 1.23.0

twolfson commented 5 years ago

If you'd like to help us add an editorconfig file, it'd be much appreciated =)

kitsguru commented 4 years ago

I have been away and playing catchup since getting back and would be happy to create the editorconfig file however mine is different from what you have been using and I am not sure what settings you prefer. tabs or spaces and 2 or 4 spaces if applicable?

twolfson commented 4 years ago

I've been using what seems to be the convention in the files (Sublime Text auto-configures when a file is opened). It looks like: