search

wbstr / vaadin-multifileupload

12 stars 23 forks source link

InternetExplorer 10 does support Multiupload #6

Closed DiabolusExMachina closed 11 years ago

DiabolusExMachina commented 11 years ago

Hi!

Internet Explorer 10 support HTML5 FileUpload so your check in SmartMultiUpload should be changed:

private boolean isBrowserNotHtml5Capable() { return webBrowser.isOpera() || (webBrowser.isIE()) || webBrowser.isTooOldToFunctionProperly(); }

to:

private boolean browserSupportsNotHTML5FileAPI() { return webBrowser.isOpera() || (webBrowser.isIE() && getBrowserMajorVersion()<10) || webBrowser.isTooOldToFunctionProperly(); }

I think the newer Versions of Opera Should work as well as they use the chrome rendering engine now :-)

juger89 commented 11 years ago

Yes, you are right. Since Vaadin 7.1.0, the ie10 user agent definition is supported and a suitable version of GWT is included in Vaadin, so MultiFileUpload in IE10 works without switching IE10 document and browser mode manually. I have checked that Opera 15+ use the chrome rendering engine so this will work too. I will cut a version 1.4 of MultiFileUpload which will contains the updates.

DiabolusExMachina commented 11 years ago

Thank you very much for the fast change!