Closed NTBBloodbath closed 3 years ago
nvim --version
NVIM v0.5.0-dev+1326-ge0a01bdf7
git --version
git version 2.31.1
Fedora 34
kitty 0.20.3
disable
PackerInstall
Thanks for the report! This looks like an error where we open the display window if there are any missing plugins before checking if plugins are disabled.
Per my comment on #362, closing this for now.
nvim --version
:NVIM v0.5.0-dev+1326-ge0a01bdf7
git --version
:git version 2.31.1
Fedora 34
kitty 0.20.3
Steps to reproduce
disable
field valueActual behaviour
PackerInstall
with disabled plugins the packer window is open with nothing to install if there's nothing to installExpected behaviour
PackerInstall
the packer window should not be opened if there's nothing to install and there are disabled pluginspacker files
Plugin specification file(s)
Example to reproduce the bug: ```lua local disabled_plugins = {'emmet'} local function has_value(tabl, val) for _, value in ipairs(tabl) do if value == val then return true end end return false end local disabled_emmet = has_value(disabled_plugins, 'emmet') return require('packer').startup(function() use { 'mattn/emmet-vim', disable = disabled_emmet, } end) ```packer compiled file
```vim " Automatically generated packer.nvim plugin loader code if !has('nvim-0.5') echohl WarningMsg echom "Invalid Neovim version for packer.nvim!" echohl None finish endif packadd packer.nvim try lua << END local time local profile_info local should_profile = true if should_profile then local hrtime = vim.loop.hrtime profile_info = {} time = function(chunk, start) if start then profile_info[chunk] = hrtime() else profile_info[chunk] = (hrtime() - profile_info[chunk]) / 1e6 end end else time = function(chunk, start) end end local function save_profiles(threshold) local sorted_times = {} for chunk_name, time_taken in pairs(profile_info) do sorted_times[#sorted_times + 1] = {chunk_name, time_taken} end table.sort(sorted_times, function(a, b) return a[2] > b[2] end) local results = {} for i, elem in ipairs(sorted_times) do if not threshold or threshold and elem[2] > threshold then results[i] = elem[1] .. ' took ' .. elem[2] .. 'ms' end end _G._packer = _G._packer or {} _G._packer.profile_output = results end time("Luarocks path setup", true) local package_path_str = "/home/adrian/.cache/nvim/packer_hererocks/2.1.0-beta3/share/lua/5.1/?.lua;/home/adrian/.cache/nvim/packer_hererocks/2.1.0-beta3/share/lua/5.1/?/init.lua;/home/adrian/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/luarocks/rocks-5.1/?.lua;/home/adrian/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/luarocks/rocks-5.1/?/init.lua" local install_cpath_pattern = "/home/adrian/.cache/nvim/packer_hererocks/2.1.0-beta3/lib/lua/5.1/?.so" if not string.find(package.path, package_path_str, 1, true) then package.path = package.path .. ';' .. package_path_str end if not string.find(package.cpath, install_cpath_pattern, 1, true) then package.cpath = package.cpath .. ';' .. install_cpath_pattern end time("Luarocks path setup", false) time("try_loadstring definition", true) local function try_loadstring(s, component, name) local success, result = pcall(loadstring(s)) if not success then print('Error running ' .. component .. ' for ' .. name) error(result) end return result end time("try_loadstring definition", false) time("Defining packer_plugins", true) _G.packer_plugins = { ["TrueZen.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/TrueZen.nvim" }, ["auto-session"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/auto-session" }, ["barbar.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/barbar.nvim" }, ["dashboard-nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/dashboard-nvim" }, edge = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/edge" }, ["editorconfig-vim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/editorconfig-vim" }, everforest = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/everforest" }, ["format.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/format.nvim" }, ["galaxyline.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/galaxyline.nvim" }, ["gitsigns.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/gitsigns.nvim" }, ["indent-blankline.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/indent-blankline.nvim" }, kommentary = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/kommentary" }, ["lazygit.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/lazygit.nvim" }, ["lsp_signature.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/lsp_signature.nvim" }, ["lspkind-nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/lspkind-nvim" }, ["lspsaga.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/lspsaga.nvim" }, ["minimap.vim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/minimap.vim" }, ["nvim-colorizer.lua"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/nvim-colorizer.lua" }, ["nvim-compe"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/nvim-compe" }, ["nvim-lspconfig"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/nvim-lspconfig" }, ["nvim-lspinstall"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/nvim-lspinstall" }, ["nvim-toggleterm.lua"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/nvim-toggleterm.lua" }, ["nvim-tree.lua"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/nvim-tree.lua" }, ["nvim-treesitter"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/nvim-treesitter" }, ["nvim-web-devicons"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/nvim-web-devicons" }, ["onedark.vim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/onedark.vim" }, ["packer.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/packer.nvim" }, ["pears.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/pears.nvim" }, ["plenary.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/plenary.nvim" }, ["popup.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/popup.nvim" }, ["presence.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/presence.nvim" }, ["range-highlight.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/range-highlight.nvim" }, ["session-lens"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/session-lens" }, ["snippets.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/snippets.nvim" }, sonokai = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/sonokai" }, ["suda.vim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/suda.vim" }, ["symbols-outline.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/symbols-outline.nvim" }, ["telescope.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/telescope.nvim" }, ["vim-deus"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/vim-deus" }, ["vim-dogrun"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/vim-dogrun" }, vimpeccable = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/vimpeccable" }, ["which-key.nvim"] = { loaded = true, path = "/home/adrian/.local/share/nvim/site/pack/packer/start/which-key.nvim" } } time("Defining packer_plugins", false) if should_profile then save_profiles() end END catch echohl ErrorMsg echom "Error in packer_compiled: " .. v:exception echom "Please check your config for correctness" echohl None endtry ```