wbuchwalter / Kubernetes-acs-engine-autoscaler

[Deprecated] Node-level autoscaler for Kubernetes clusters created with acs-engine.
Other
71 stars 22 forks source link

Scale agentpool based on label/nodeSelectors #41

Open oryagel opened 7 years ago

oryagel commented 7 years ago

Hi. We have two agent pools, let's call them pool1 and pool2. I have a pod with nodeSelector: {agentpool: pool2}. The autoscaler removed the nodes of pool2. Now the log of the autoscaler says KubePod(default, some-pod-name) fits on k8s-pool1-12212174-0. This will not work since that specific pod can't run on this specific node due to the nodeSelector configuration.

Thanks

wbuchwalter commented 7 years ago

Hi @oryagel, Currently nodeSelectors are not supported by the autoscaler. But you can use the wbuchwalter/kubernetes-acs-engine-autoscaler:labels image which does have beta support.

oryagel commented 7 years ago

Thanks. I'll try that. When do you plan to merge into master?

wbuchwalter commented 7 years ago

'acs-engine' added a feature recently, where you can declare the labels for your nodes in the json file directly. I need to add support for this instead of reading the labels from live nodes. Then I should be able to merge.

nalthoff commented 7 years ago

Great product! I would love to see this!