search

wbuchwalter / Kubernetes-acs-engine-autoscaler

[Deprecated] Node-level autoscaler for Kubernetes clusters created with acs-engine.
Other
71 stars 22 forks source link

Support deleting managed-disk nodes #50

Closed kim0 closed 7 years ago

kim0 commented 7 years ago

I have an acs-engine cluster with managed-disks. When the auto-scaler tries deleting a node, it explodes as below

2017-08-25 16:28:06,581 - autoscaler.engine_scaler - INFO - deleting node k8s-agentspool-29019338-0
Exception in thread Thread-3:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/usr/local/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/app/autoscaler/engine_scaler.py", line 127, in delete_node
    self.delete_resources_for_node(node)
  File "/app/autoscaler/engine_scaler.py", line 73, in delete_resources_for_node
    storage_infos = vm_details.storage_profile.os_disk.vhd.uri.split('/')
AttributeError: 'NoneType' object has no attribute 'uri'

2017-08-25 16:28:06,943 - autoscaler.cluster - INFO - ++++ Maintenance Ends ++++++
skuda commented 7 years ago

Same problem here.

wbuchwalter commented 7 years ago

This issue has been fixed. You can get the fix by using the image tag 2.1.1.

skuda commented 7 years ago

Yes, it's working fine now, thanks!.