search

wbuchwalter / tslint-loader

tslint loader for webpack
192 stars 65 forks source link

Get custom tsconfig.json from the `tsConfigFile` option as the docs says #102

Open danikaze opened 6 years ago

danikaze commented 6 years ago

Documentation in README.md says that the custom tsconfig.json is read by the tsConfigFile option, but it doesn't work because the code is trying to get it from configFile field of the options.

Enabled the tsConfigFile without changing the current one to provide compatibility with previous versions, but follow the documentation.

The tsconfig.json file is needed for rules that need type check, so it's something necessary to have working.

bhovhannes commented 5 years ago

@danikaze , configFile option is used to specify tslint configuration and tsConfigFile is used to specify custom tsconfig.json - typescript configuration. These 2 options server for different purpose and I think it will be wrong to mix them.

Do you have any issue you're trying to fix with you PR?