search

wbuchwalter / tslint-loader

tslint loader for webpack
192 stars 65 forks source link

Tslint should be of version 4+ #67

Closed alexeyuzlov closed 7 years ago

alexeyuzlov commented 7 years ago

I tried to update tslint to version 5.0.0, but I got an error on build

ERROR in ./src/polyfills.browser.ts Module build failed: Error: Tslint should be of version 4+ at Object.module.exports (\node_modules\tslint-loader\index.js:121:11) @ multi (webpack)-dev-server/client?./src/polyfills.browser.ts

version of tslint-loader: 3.4.3

vanor89 commented 7 years ago

Happening to me as well

Ketec commented 7 years ago

Same - it does not work with 5.0.0 anymore.

because of "tslint": "^4.0.0". caret does not go beyond major versions, may need ">4.0.0" or such now.

sonicoder86 commented 7 years ago

There is a check for the version in code to avoid other mysterious crashes. It is also inside package.json

"peerDependencies": {
  "tslint": "^4.0.0"
}

You can upgrade it in the repo and submit a pull request. It would cause a major version change in tslint-loader.

skiabox commented 7 years ago

I confirm that I get the same error!

arthur-melo commented 7 years ago

If you updated your project and your build is breaking, just rollback to the latest TSLint 4 version (4.5.1) and it will work fine. That's the only alternative until upstream update.

sonicoder86 commented 7 years ago

It should work now with version 3.5.1