search

wbuchwalter / tslint-loader

tslint loader for webpack
193 stars 65 forks source link

fix emitted errors & allow tslint@>=4.0.0 #70

Closed jskrzypek closed 7 years ago

jskrzypek commented 7 years ago

Webpack now expects proper Error instances to be passed to emitError() & emitWarning(): https://github.com/webpack/webpack/blob/master/lib/NormalModule.js#L112-L121

This looks like it wasn't an issue the last time the tests ran, but is blocking the other PRs (#68, #69) that are trying to fix the semver dep to allow tslint@^5.0.0

bastienmoulia commented 7 years ago

You forget the change of semver in https://github.com/jskrzypek/tslint-loader/blob/8dbe0ad428b7a388d290d807b099562c7b1366f9/index.js#L122

But i don't test it right now, maybe it's not needed.

sonicoder86 commented 7 years ago

@jskrzypek why delete the error stack?

jskrzypek commented 7 years ago

@blacksonic The error stack is actually pointing to the location where the error was created, in this case tslint-loader/index.js, which isn't actually where the problem is. The tests failed when I left the stack in place, but passed after deleting it.

jskrzypek commented 7 years ago

@bastienmoulia yes I forgot that part, I added it and amended the commit

sonicoder86 commented 7 years ago

Published it, 3.5.1