webpack-4.0.0-beta.2 compat: options deprecated

claudiordgz commented 6 years ago

Fixes #94

I wanted to try out webpack-4.0.0-beta.2 to see if my bundle would build any faster.

Turns out Compiler.options is now deprecated so I check for it before using it.

I was able to get some sweet ts-lint on my project after these 2 changes.

sonicoder86 commented 6 years ago

Thanks for the fix!

thilak-rao commented 6 years ago

Ran into the same while trying out Webpack 4 today. Thanks for the fix @claudiordgz

@blacksonic now that Webpack 4 is stable, it would be nice if you could publishing a new version of tslint-loader to npm?

I got around my issue by referencing @claudiordgz's commit (https://github.com/wbuchwalter/tslint-loader/commit/093230076f3b453c4f8b7aa2ee074932aa109e84) in my package.json

"devDependencies": {
    "ts-loader": "4.0.0",
    "tslint": "5.9.1",
    "tslint-clean-code": "0.2.3",
    "tslint-loader": "https://github.com/wbuchwalter/tslint-loader.git#093230076f3b453c4f8b7aa2ee074932aa109e84",
    "typescript": "2.7.2",
    "webpack": "4.0.0",
    "webpack-cli": "2.0.9"
  }

mbuckley commented 6 years ago

@blacksonic - I'm looking to pickup this fix in my webpack v4 setup. Would you mind creating a release tag that includes this fix?

https://github.com/wbuchwalter/tslint-loader/compare/v3.5.3...master

wbuchwalter / tslint-loader

webpack-4.0.0-beta.2 compat: options deprecated #95