search

wbyoung / avn

Automatic Version Switching for Node
MIT License
1.14k stars 54 forks source link

Rework profile.js to use shellInitScriptChooser() #51

Open edsfocci opened 7 years ago

edsfocci commented 7 years ago

Rework 'avn setup' to use .bashrc or .bash_profile according to the algorithm @wbyoung talked about in #50

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-11.4%) to 88.593% when pulling a4df2f8e9d72b9f6b41c9634a33ceb2eb01744cb on edsfocci:add-bashrc-to-setup-attempt-2 into 24e1b1d2563064df5710669ed1ead75fb29b1dbf on wbyoung:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-9.2%) to 90.775% when pulling 3a12d2b0f865618f66c9ad1f81e7157564224165 on edsfocci:add-bashrc-to-setup-attempt-2 into 24e1b1d2563064df5710669ed1ead75fb29b1dbf on wbyoung:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-8.0%) to 92.015% when pulling 569aa22f36d687111ed628821a895c1c23edb280 on edsfocci:add-bashrc-to-setup-attempt-2 into 24e1b1d2563064df5710669ed1ead75fb29b1dbf on wbyoung:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-8.0%) to 92.015% when pulling 644106496a1d2fd7dbe6c50b06f7c4de8d5b7fb6 on edsfocci:add-bashrc-to-setup-attempt-2 into 24e1b1d2563064df5710669ed1ead75fb29b1dbf on wbyoung:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-8.0%) to 92.015% when pulling 5bca4a72381139299afab25dbc2f78453b3c97b3 on edsfocci:add-bashrc-to-setup-attempt-2 into 24e1b1d2563064df5710669ed1ead75fb29b1dbf on wbyoung:master.

edsfocci commented 7 years ago

I made the changes you suggested, and the code currently passes in Travis. I'll work on adding the tests later.

wbyoung commented 7 years ago

@edsfocci I just stumbled across this resolution of init scripts by yarn. It seems as though they'd probably have worked out most platform idiosyncrasies and it does seem quite simple.

evenfrost commented 5 years ago

Any update on this? Ubuntu uses .profile instead of .bash_profile, and avn doesn't work for me at all until moving scripts to .bashrc.