Closed duckontheweb closed 6 years ago
(avn may want to move to eslint; jshint isn't up to par anymore)
Sorry, I misinterpreted this. It's actually jscs
that is raising the errors.
It looks like all of the issues being caught by jscs
run counter to the overall coding style of that plugin. Since jshint
is running against this code already, maybe it makes sense to just turn off jscs
and only use jshint
(or update to eslint
).
jscs is also deprecated; its team and rules were absorbed into eslint over a year ago.
@wbyoung if this is something you want to do I can put in another PR once I’m done with the alias work
Sent with GitHawk
@duckontheweb yes, it'd be great to have avn
, avn-nvm
, and avn-n
updated to ESLint
. Along the same lines, I've also been thinking about using babel to allow async
/await
and clean up the code base.
If you're interested in making those changes, the help would be much appreciated! 😄
Definitely. I'll open up separate issues for each of these.
Resolved by https://github.com/wbyoung/avn-nvm/commit/fd47799dda5d359989b1fd233466966c253b5226, but @duckontheweb is also working on transitioning to ESLint.
See #67.
Please describe your issue clearly and also include all details below.
Details
v4.8.6
I'm getting a number of
jshint
failures when running the tests foravn-nvm
, all of them in/index.js
(see below for full details). Would you like me to clean these up before submitting any PRs related to #43?