Open duckontheweb opened 6 years ago
@wbyoung It looks like the checks are failing because the latest version of eslint
requires node >= v4
and the TravisCI build uses v0.12.7
:
$ npm view eslint engines
> { node: '>=4' }
I briefly tried to resolve this by using an earlier version of eslint
. The problem is that the eslint-config-airbnb*
packages have a slew of dependencies and we would need to be very specific in which ones we pulled. I can do this if you'd like, but I'm wondering if it would be easier to upgrade the Travis Node version to one of the LTS version above v4.
@duckontheweb the solution there is to not run the linter in every matrix build, but to explicitly include it, and only run it in lts/*
. There's no reason to run the linter more than once :-)
See https://github.com/ljharb/is-callable/blob/master/.travis.yml#L22-L33 for an example of many travis-ci best practices.
This removes
jshint
andjscs
as the linters and replaces them witheslint
. An attempt was made to keep the rules as consistent as possible during the transition. However, there were a few areas where it seemed more appropriate to bring the code inline with the linting rules rather than adjusting the rules accordingly (see 60f82a8, 55dcbe9, and c28f3da).@wbyoung If you would like, I can turn back on some of the default
airbnb
rules and bring the code base up to speed with those, but I'd like to get guidance from you first on how you would like to proceed.Addresses #67.