Closed hopkins-tk closed 7 years ago
( Im putting it here because stupid github has hidden those comments )
this build entry points are not doing what you think they are doing.
index.ts
imports define
from skate, so as a end result. skate will be always bundled. This is not what we wanted.
What you need to do:
externals
for main index.ts packages
externals: {
skatejs: 'skatejs'
}
index-with-deps.ts
that vendor import is completely unnecessary and may increase bundle size. We are using three shaking, so only used functions/imports are bundled. only thing that you need to import there are polyfills
this will be addressed in another PR https://github.com/wc-catalogue/blaze-elements/issues/177
Great job @hopkins-tk will take a look tomorrow. If everything will be OK, I'll merge it. Thx!
Build of the whole project will now produce: