feat(app-layout): add - Githubissues

wc-catalogue / blaze-elements

Web Component Blaze Elements

https://wc-catalogue.github.io/blaze-elements/

MIT License

10 stars 4 forks source link

feat(app-layout): add #154

Closed elmariofredo closed 7 years ago

hopkins-tk commented 7 years ago

I know we have agreed on the slotted version, but as it can be seen now it requires following components to be bundled with app layout component:

Drawer
Nav
NavContent
Overlay

So it might be something we should reconsider in the next iteration...

elmariofredo commented 7 years ago

@hopkins-tk please can you expand your thoughts on bundling other elements? I thought that we did discuss this issue and agreed that this won't be problem when developer will use blaze-elements bundle where it should get deduplicated.

hopkins-tk commented 7 years ago

@elmariofredo you are right - that's why I just put it so that we can discuss it, but leave it now as is...

I am not worried about size of the produced bundle, but the number of necessary classes/files in the source code...

But again for the fist iteration it is fine.