search

wc-catalogue / blaze-elements

Web Component Blaze Elements
https://wc-catalogue.github.io/blaze-elements/
MIT License
10 stars 4 forks source link

packaging: import packages via node_modules instead of relative paths #165

Closed Hotell closed 7 years ago

Hotell commented 7 years ago

Current behavior

We import from other package via relative path, which is a big no no ( packages are bundled multiple times )

Expected behavior

instead of import {Button} from '../button we need to import {Button} from '@blaze-elements/button'

this should be provided by Lerna. Type definitions needs to be properly generated as well for this to work withou compilation errors

Hotell commented 7 years ago

again always include Closes #Number when merging to automatically close issues ( also important for changelog )

cheersssss

Hotell commented 7 years ago

Closed by #169