davidrus commented 7 years ago

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/wc-catalogue/blaze-elements/blob/master/docs/CONTRIBUTING.md#commit
[x] There are no linting errors and code is properly formatted (your run before push yarn ts:format && yarn ts:lint:fix)
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

193

What is the new behavior? CustomEvent changed to GenericEvents.CustomChangeHandler and data structure for emit has been changed to event.detail.value=value

Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: Input changed data structure for emitting data to event.detail.value instead of event.detail.data

Hotell commented 7 years ago

just w8 for CI, then rebase and merge. thx!

davidrus commented 7 years ago

I am w8ing for miracle ....

wc-catalogue / blaze-elements

input,tag: replace CustomEvent to GenericHandlers.CustomChangeEvent and BC input onChange API #201

193