Closed elmariofredo closed 7 years ago
I see two problems here
According to this issue semantic-release
use npm gitHead which slightly undocumented property to determine which revision was used to publish particular npm package version. I we look for example at @blaze-elements/input we will get 1ec9488803ff8f1845b07a949908fde13bc84e63
which doesn't exists, I guess it wasn't properly pushed to master for some reason.
According to this code lerna-semantic-release is determining affected packages base on affect
string in commit message which is used as standart in atlaskit repo.
Conclusion: Even if we fix first issue manually we still are not 100% sure it won't occur again as root cause is still yet to be discovered. Then we have to strictly use affect
string which is in my opinion duplicate to scope. I have started investigate around custom solution from https://github.com/material-components/material-components-web/tree/master/scripts which is doing exactly what @Hotell proposed.
I will release manually following packages to resolve current issues
Malformed packages:
all problematic packages were manually released
This seems to be still happening as seen in https://travis-ci.org/wc-catalogue/blaze-elements/builds/209739945#L905 for some strange reason tags are published, but appear in weird detached state which result command git branch --no-color --contains
with empty output instead of master
.
I will try to mirror approach of atlassian guys here and š for miracle, otherwise digging deep into git internals in inevitable š
After discussing with team I will prepare testing repo where we can test lerna-semantic-release functionality without risk of poisoning blaze-elements repo.
I'm very happy that everyone in the team reads my emails...
@davidrus @hopkins-tk
I'm submitting a ... (check one with "x")
Current behavior Current release is failing with errors as
and
as you can see if you open line https://travis-ci.org/wc-catalogue/blaze-elements/jobs/204198870#L906
Expected behavior lerna sematic release should work