Closed davidrus closed 7 years ago
This should fix just affected package which is select in this case, not other packages. Rather create issue for others. thx
anyway good job, although there is a opinion across the team that I'm constantly nitpicking and trying to "Educate" others in a Force manner.
To prevent that please assign this to someone who can behave (according to team) and who will not have comments against your work. thx
I think that we might be able to agree on following (we can discuss it tomorrow):
and
to describe what it is about, it should be more commitsHowever as this PR was considered more like remove @bind
decorators, it has single thing it is about, even though cross several scopes.
Sure, could be multiple commits in single PR, but than we would end-up with something like this once squashing & merging.
We can start doing it correctly as we will have to if we will want to use scopes instead of affects - but currently, we use affects :disappointed:
Replacement PR were created:
thank you @hopkins-tk for your PRs and @Hotell for comments. So I will close this PR to prefer #250 #249
affects: @blaze-elements/calendar, @blaze-elements/select, @blaze-elements/tag
Please check if the PR fulfills these requirements
yarn ts:format && yarn ts:lint:fix
)What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here) decko does not working in ie
What is the new behavior? decko removed :)
Does this PR introduce a breaking change? (check one with "x")