wc-catalogue / blaze-elements

Web Component Blaze Elements
https://wc-catalogue.github.io/blaze-elements/
MIT License
10 stars 4 forks source link

fix: remove @bind decorators from 'decko' because IE error #246

Closed davidrus closed 7 years ago

davidrus commented 7 years ago

affects: @blaze-elements/calendar, @blaze-elements/select, @blaze-elements/tag

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) decko does not working in ie

What is the new behavior? decko removed :)

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No
Hotell commented 7 years ago

This should fix just affected package which is select in this case, not other packages. Rather create issue for others. thx

Hotell commented 7 years ago

anyway good job, although there is a opinion across the team that I'm constantly nitpicking and trying to "Educate" others in a Force manner.

To prevent that please assign this to someone who can behave (according to team) and who will not have comments against your work. thx

hopkins-tk commented 7 years ago

I think that we might be able to agree on following (we can discuss it tomorrow):

However as this PR was considered more like remove @bind decorators, it has single thing it is about, even though cross several scopes. Sure, could be multiple commits in single PR, but than we would end-up with something like this once squashing & merging.

We can start doing it correctly as we will have to if we will want to use scopes instead of affects - but currently, we use affects :disappointed:

hopkins-tk commented 7 years ago

Replacement PR were created:

davidrus commented 7 years ago

thank you @hopkins-tk for your PRs and @Hotell for comments. So I will close this PR to prefer #250 #249