search

wc-catalogue / blaze-elements

Web Component Blaze Elements
https://wc-catalogue.github.io/blaze-elements/
MIT License
10 stars 4 forks source link

refactor(accordion): follow current styleguides and fix ts issues #254

Closed elmariofredo closed 7 years ago

elmariofredo commented 7 years ago

components is not currently following our current styleguides and tsc is returning following errors


21   readonly detail: StateChangedEventDetail
                      ~~~~~~~~~~~~~~~~~~~~~~~

../collapsible/Collapsible.tsx(21,20): error TS4033: Property 'detail' of exported interface has or is using private name 'StateChangedEventDetail'.

24 export class Collapsible extends Component<CollapsibleProps> {
                                              ~~~~~~~~~~~~~~~~

../collapsible/Collapsible.tsx(24,44): error TS4020: Extends clause of exported class 'Collapsible' has or is using private name 'CollapsibleProps'.

26   static get props() {
                ~~~~~

../collapsible/Collapsible.tsx(26,14): error TS4038: Return type of public static property getter from exported class has or is using name 'PropOptions' from external module "/Users/mario/ngParty/blaze-elements/node_modules/skatejs/src/ts-typings/api" but cannot be named.

we need to fix that