search

wc-catalogue / blaze-elements

Web Component Blaze Elements
https://wc-catalogue.github.io/blaze-elements/
MIT License
10 stars 4 forks source link

refactor(toggle): follow current style guides and fix typescript issues #273

Closed elmariofredo closed 7 years ago

elmariofredo commented 7 years ago

components is not currently following our current style guides and tsc is returning following errors

27       'bl-toggle': GenericTypes.IntrinsicCustomElement<ToggleProps> & GenericTypes.IntrinsicBoreElement<Props, Events>
                                                          ~~~~~~~~~~~

Toggle.tsx(27,56): error TS4033: Property ''bl-toggle'' of exported interface has or is using private name 'ToggleProps'.

27       'bl-toggle': GenericTypes.IntrinsicCustomElement<ToggleProps> & GenericTypes.IntrinsicBoreElement<Props, Events>
                                                                                                           ~~~~~

Toggle.tsx(27,105): error TS4033: Property ''bl-toggle'' of exported interface has or is using private name 'Props'.

27       'bl-toggle': GenericTypes.IntrinsicCustomElement<ToggleProps> & GenericTypes.IntrinsicBoreElement<Props, Events>
                                                                                                                  ~~~~~~

Toggle.tsx(27,112): error TS4033: Property ''bl-toggle'' of exported interface has or is using private name 'Events'.

32 export class Toggle extends Component<ToggleProps> {
                                         ~~~~~~~~~~~

Toggle.tsx(32,39): error TS4020: Extends clause of exported class 'Toggle' has or is using private name 'ToggleProps'.

34   static get props() {
                ~~~~~

Toggle.tsx(34,14): error TS4038: Return type of public static property getter from exported class has or is using name 'PropOptions' from external module "/Users/mario/ngParty/blaze-elements/node_modules/skatejs/src/ts-typings/api" but cannot be named.