search

wc-catalogue / blaze-elements

Web Component Blaze Elements
https://wc-catalogue.github.io/blaze-elements/
MIT License
10 stars 4 forks source link

refactor(tooltip): follow current style guides and fix typescript issues #276

Closed elmariofredo closed 7 years ago

elmariofredo commented 7 years ago

components is not currently following our current style guides and tsc is returning following errors

21       'bl-tooltip': TooltipProps & Partial<HTMLElement>,
                       ~~~~~~~~~~~~

Tooltip.tsx(21,21): error TS4033: Property ''bl-tooltip'' of exported interface has or is using private name 'TooltipProps'.

26 export class Tooltip extends Component<TooltipProps> {
                                          ~~~~~~~~~~~~

Tooltip.tsx(26,40): error TS4020: Extends clause of exported class 'Tooltip' has or is using private name 'TooltipProps'.

28   static get props() {
                ~~~~~

Tooltip.tsx(28,14): error TS4038: Return type of public static property getter from exported class has or is using name 'PropOptions' from external module "/Users/mario/ngParty/blaze-elements/node_modules/skatejs/src/ts-typings/api" but cannot be named.