search

wc-catalogue / blaze-elements

Web Component Blaze Elements
https://wc-catalogue.github.io/blaze-elements/
MIT License
10 stars 4 forks source link

refactor(range): follow current style guides and fix typescript issues #288

Closed elmariofredo closed 7 years ago

elmariofredo commented 7 years ago

components is not currently following our current style guides and tsc is returning following errors

22 export class Range extends Component<RangeProps> {
                                        ~~~~~~~~~~

Range.tsx(22,38): error TS4020: Extends clause of exported class 'Range' has or is using private name 'RangeProps'.

24   static get props() {
                ~~~~~

Range.tsx(24,14): error TS4038: Return type of public static property getter from exported class has or is using name 'PropOptions' from external module "/Users/mario/ngParty/blaze-elements/node_modules/skatejs/src/ts-typings/api" but cannot be named.

6   static get props() {
               ~~~~~

index.demo.tsx(6,14): error TS4038: Return type of public static property getter from exported class has or is using name 'PropOptions' from external module "/Users/mario/ngParty/blaze-elements/node_modules/skatejs/src/ts-typings/api" but cannot be named.