wc-duck / datalibrary

Open Source Data Library for data serialization.
Other
42 stars 8 forks source link

Added test of json writer which crashed on array of struct with pointer #144

Closed Tisten closed 1 year ago

Tisten commented 1 year ago

And fixed the crash

The bug here was the fall through on old line 651

This PR also fixes a crash where unions weren't checked in dl_txt_unpack_write_subdata()

wc-duck commented 1 year ago

Trying to look at this on my phone... kind of impossible so I'll have to check it out tomorrow:D

Tisten commented 1 year ago

No hurry at all. The fixes are done, so I'm making these PRs to avoid diverging my fork from your main branch over time, and to get feedback to improve my code. ;)