search

wc-duck / datalibrary

Open Source Data Library for data serialization.
Other
42 stars 8 forks source link

Added merging of identical strings #153

Closed Tisten closed 1 year ago

Tisten commented 1 year ago

A first stab at https://github.com/wc-duck/datalibrary/issues/14 I don't think merging strings need an option, they are const. Also note that this initial change will only merge strings when doing binary store, and not when doing text pack. I hope developing in iterations is okay. :)

wc-duck commented 1 year ago

Iterations are absolutely fine :) And yes, merging strings should be fine, however arrays is something we need to think more about as it would not be clear if they alias and would then be unclear if modifying the data that you would edit multiple arrays. There i think a flag that default to off is needed!