Closed lundmark closed 6 years ago
Also... is it possible to turn off whitespace diffs in github? This shit be craycray.
This is failing because the build is already failing on these points.
Except for the "to big default"-check this looks fine! I'll merge when that check is moved.
Awesome! What's wrong with the too big default value?
I think the check should be done when parsing the typelib, not when packing in instance... Or did I miss something when reading the changes on my phone and a train? :)
No you are entirely correct. Interestingly enough, that already exists!
Should I check for too big value though?
That is already there as well! I'll just remove the check and commit!
As you can see I added unittesting for using true/false values instead of 1/0 on bitfields. I think this is a really good thing because it's something that our content creators think is really important.
Can't merge on my phone but consider this merged an closed!
Apparently I can do it myself? Thanks for the trust!
Previously, having defaults for bitfields did not yield the correct result. This was because bitfields can be sub-byte sized and previous implementation of defaults did not take this into consideration.
I'm not 100% certain that I've done everything correct so please review the code in dl_txt_pack before admitting the pull request.