search

wc-duck / datalibrary

Open Source Data Library for data serialization.
Other
42 stars 8 forks source link

Inline array of bitfield-types is silently ignored #76

Closed lundmark closed 6 years ago

lundmark commented 6 years ago

Having a member on a struct like this: { "name" : "this_is_not_what_I_expected", "type" : "bitfield:1[8]" }

Either the feature should be supported, or DL should fail/warn about unsupported type.

wc-duck commented 6 years ago

Yeah... That is clearly wrong. Will have to turn that into on error as I have no idea what an array of bitfields would actually mean.

lundmark commented 6 years ago

Yes, this should clearly be an error :)

On Fri, Feb 16, 2018 at 7:59 PM, Fredrik Kihlander <notifications@github.com

wrote:

Yeah... That is clearly wrong. Will have to turn that into on error as I have no idea what an array of bitfields would actually mean.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wc-duck/datalibrary/issues/76#issuecomment-366327459, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXOMkk-qvQ_EuoXsxJCIM9VcbH62FIqks5tVc_-gaJpZM4SISsU .