search

wcandillon / canvaskit-js

A polyfill of CanvasKit that uses browser APIs
MIT License
79 stars 8 forks source link

What's missing to support `dash` on `path`? #15

Closed kimchouard closed 1 year ago

kimchouard commented 1 year ago

I just got my start-react-native subscription. Thanks @wcandillon for all your work on this. 🙏

I'm eager to try canvaskit-js, and potentially contribute to the project. The only missing feature for me is the support for dash on the path API.

What's missing to be able to support this? If you have a clear path to implement this, happy to help. 🙌🏻

wcandillon commented 1 year ago

I will give it a try. There is an API you can safely use to implement any kind of custom path effects: CanvasKit.ContourMeasureIter: https://github.com/wcandillon/canvaskit-js/blob/fdea2d26a3dd586e19a9b00462c99498c7a0ebf4/package/src/__tests__/Paths/setup.ts#L48

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 2.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

kimchouard commented 1 year ago

Amazing, thanks for bringing that in so quickly! 😎

Will give it a try on my refactor next week and will let you know if I face any issues.

Merci 🙌🏻