search

wcandillon / react-native-img-cache

Image Cache for React Native
https://hackernoon.com/image-caching-in-react-native-96d8df33ca84
Apache License 2.0
731 stars 143 forks source link

Change react-native-fetch-blob to rn-fetch-blob #105

Closed domben closed 5 years ago

domben commented 6 years ago

react-native-fetch-blob is no longer being actively maintained so it is advised to switch over to rn-fetch-blob

This fix should resolve Issue 95

iksent commented 5 years ago

@wcandillon, I think you should merge pull request or make such changes by yourself.

dennisaskeland commented 5 years ago

Maybe add a short note in readme about changing to rn-fetch-blob manually if not merging into master as it took me quite a while to figure out the problem as I followed tips to swap out react-native-fetch-blob, but no mention of changing in the module as well

IcebergRage commented 5 years ago

You really should merge this pull request :)

elieteyssedou commented 5 years ago

@wcandillon, hi !

Will you maintain your package ? Do we have to make a definitive fork to fix this issue ? 🤔

It would be great if you could just merge this PR and bump the package. Please 😊

wcandillon commented 5 years ago

thanks!

elieteyssedou commented 5 years ago

Thanks a lot ! You saved me a lot of time. 👌🏻(I am currently looking for the version 1.5.4)

dmackinn commented 5 years ago

I appreciate the update, thank you for merging this in.

FYI the Circle CI test for this PR merge is marked as failed. https://circleci.com/gh/wcandillon/react-native-img-cache

elieteyssedou commented 5 years ago

@wcandillon sorry to bother you, any update on the release ? Can I help ?

wcandillon commented 5 years ago

good point, I will try to publish later today, sorry about that!

elieteyssedou commented 5 years ago

Thank you a lot, and thanks for your package, it works very well ! 👍👏🏻

wcandillon commented 5 years ago

done :) thank you for your patience.

On Mon, Dec 3, 2018 at 5:03 PM Elie notifications@github.com wrote:

Thank you a lot, and thanks for your package, it works really well ! 👍 👏🏻

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wcandillon/react-native-img-cache/pull/105#issuecomment-443763391, or mute the thread https://github.com/notifications/unsubscribe-auth/AASr1kuMn3UMtw1ad3Bg-TMw32aaAq41ks5u1UtfgaJpZM4WbNaF .