wcandillon / react-native-webgpu

React Native implementation of WebGPU using Dawn
MIT License
419 stars 19 forks source link

feat: add visionos support #88

Closed okwasniewski closed 1 month ago

okwasniewski commented 2 months ago

This PR adds visionOS support.

As I still can't get the build to work locally I decided to try to build dawn library on the CI

okwasniewski commented 2 months ago

Hey @wcandillon,

As I've been able to run the example app on visionOS are you okay with adding visionOS to the example folder? I will then finish the work on this. We can also consider migrating the example to use https://github.com/microsoft/react-native-test-app, which we've been using at Callstack for our test applications in OSS repos.

https://github.com/user-attachments/assets/2d5c618e-5b15-4cef-8558-d4ddf8c70667

wcandillon commented 2 months ago

@okwasniewski Sorry that I didn't mention it earlier but today I migrated to a monorepo where the example app is an expo dev-client app. Could that work for you? Let me know.

wcandillon commented 2 months ago

If you make a separate PR just for the build and so we have the prebuilt binaries + have them on github actions, I will merge it publish it asap.

okwasniewski commented 2 months ago

Expo is unfortunately not supported (yet). If this is going to be a monorepo how about a separate project? I would love to run some visionOS CI to ensure that subsequential releases are not breaking the support as this library is crucial for that platform. Yeah, I can create a separate PR without the example

wcandillon commented 2 months ago

yes that's a great idea :)

Also in the future all examples will be centralized in a single package used by all apps. (depending on how fast I'm going with the current migration).

On Thu, Aug 29, 2024 at 10:31 AM Oskar Kwaśniewski @.***> wrote:

Expo is unfortunately not supported (yet). If this is going to be a monorepo how about a separate project? I would love to run some visionOS CI to ensure that subsequential releases are not breaking the support as this library is crucial for that platform. Yeah, I can create a separate PR without the example

— Reply to this email directly, view it on GitHub https://github.com/wcandillon/react-native-webgpu/pull/88#issuecomment-2317017950, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKXVVRSSNJJZ23TBJXCB3ZT3L5RAVCNFSM6AAAAABNDVGXI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJXGAYTOOJVGA . You are receiving this because you were mentioned.Message ID: @.***>

wcandillon commented 2 months ago

I think this is cool :) I just migrated to the monorepo. Could you add an visionpro in apps and with a simple example (e.g the red triangle). I will factorize the examples in its own package to be used in every apps/ And potentially we can even run e2e tests on the vision pro simulator if supported.

Thank you so much for your hardwork. Hope the monorepo stuff is not throwing a wrench into your work.

okwasniewski commented 2 months ago

I think this is cool :) I just migrated to the monorepo. Could you add an visionpro in apps and with a simple example (e.g the red triangle). I will factorize the examples in its own package to be used in every apps/ And potentially we can even run e2e tests on the vision pro simulator if supported.

Thank you so much for your hardwork. Hope the monorepo stuff is not throwing a wrench into your work.

No worries, I will add this!

This might need to wait a little as I'm traveling for React Universe Conf next week but I will get back to this as soon as I can 👍🏻

okwasniewski commented 1 month ago

Im going to close this one as the visionOS example added after https://github.com/wcandillon/react-native-webgpu/pull/109 gets merged (as react-native-test-app supports visionOS)

wcandillon commented 1 month ago

that's exciting. So react-native-test-app is the way to go I didn't know about this thing

Saadnajmi commented 1 month ago

@wcandillon We've switched a lot of React native libraries to use react-native-test-app as an easy way to keep maintenance and get out of tree platform support. visionOS and macOS for example get added with one file. My PR needs some work still, so I'd appreciate if anyone recognizes the errors I'm running into 😅