search

wcandillon / swagger-js-codegen

A Swagger Codegen for typescript, nodejs & angularjs
Apache License 2.0
693 stars 286 forks source link

Merge ts branch into master. #85

Closed alexkrauss closed 8 years ago

alexkrauss commented 9 years ago

... and release to npm, since this is really useful. :-)

laurensvanpoucke commented 9 years ago

+1, is also very useful for me :)

wcandillon commented 9 years ago

@alexkrauss Is is possible to clean up the template folder by making filenames more explicits? For instance node-typedef.mustache doesn't sound like a good name. In the test you added, can you check if the generated file is typescript valid? using tslint for instance?

alexkrauss commented 9 years ago

@wcandillon What names would you suggest then?

In the test, the result is already checked against a predefined expectation, so I'm not sure, adding a tslint check adds anything except overhead. I was thinking of this more as a unit test, with a predefined input and output... One could also think about proper integration testing, but then we would also have to make sure that the generated type definitions match the generated code... This is certainly more work.

wcandillon commented 8 years ago

@alexkrauss Thank you so much for doing this. I have made a branch that superseeds this. I reused the typeconvertion function you wrote.