search

wcde / sd-webui-refiner

Webui Extension for integration refiner in generation process
161 stars 12 forks source link

replace refiner steps with "base to refiner ratio" #20

Closed dhwz closed 11 months ago

dhwz commented 11 months ago

This way it's better to understand (see also https://github.com/wcde/sd-webui-refiner/issues/13) what is meant. Added also a note so inexperienced users know they may get bad results if they play with that value.

lisanet commented 11 months ago

The description of the slider value is slightly misleading. 'base to refiner ratio' is base / refiner and therefor for base 20 and refiner 4, the ratio is 20 / 4 = 5

If it should be described as 'refiner to base ratio', the range has to be changed, because refiner 4 to base 20 = 4 / 20 = 0.2 and therefor the range should be 0 to 0.5 with default 0.2. IMO this is the way to go.

If the default value should be 0.8 with range 0.5 to 1.0 then it should be described as 'percentage of base steps from total' or 'percentage of steps when refiner starts'

;-)

Edit: the 'refiner to base ratio' would be consistent with Stability AI's own StableSwormUI https://github.com/Stability-AI/StableSwarmUI/commit/370c46fd1d3c3559ff7b4266df4538cfb80e031a

lisanet commented 11 months ago

Thank you for your comment and calling me names. (Ahh, I see, you've removed your $%&*...)

So, as it's open source, I will do it on my own.

Have a nice day.

BTW, mathematics is not a matter of opinion regardless how many others say, that a base to refiner ratio of 0.8 means 80% for base and 20% for refiner.