Open imgurbot12 opened 4 years ago
mcepl
commented
3 years ago Except that the tests don’t look like passing. See py3-setup-test-log.txt for complete logs.
Concerning comparing two lists? Does order matter? Shouldn't we compare just two sets?
imgurbot12
commented
3 years ago Except that the tests don’t look like passing. See py3-setup-test-log.txt for complete logs.
Concerning comparing two lists? Does order matter? Shouldn't we compare just two sets?
interesting. I've never had an issue when running the tests directly with python3 -m pypub.tests. I've updated the test to use sets to avoid this issue however. nice catch :)
evmer
commented
1 year ago Updates? Can we merge?
imgurbot12
commented
1 year ago Updates? Can we merge?
I'm happy with where the PR is now, but we'd have to wait for the author to complete the merge since I obviously don't have permissions to do it on my own. Unfortunately I haven't seen any engagement from him at all so far.
avalonv
commented
1 year ago @imgurbot12 have you considered publishing your own fork on PyPi under a new name? Normally that might not be super polite, but I think after two years it's probably okay
imgurbot12
commented
1 year ago @avalonv I've decided to do just that and just managed to finalize the first release. This is my first pypi published project so PRs are welcome lol.
Here's the link to the new project if anyone is interested: https://pypi.org/project/pypub3/
Hey there! I wanted to use this library in python3, but noticed the code could use some improvements. I was planning on using the library to generate my own ebooks for different publications online, so I decided to clean it up entirely and basically complete an entire re-write inspired by your original design.
The new code has been fully tested, and I've even shoved the results through epubcheck to ensure everything works as intended. If you like the new code design please consider merging it :)