invoice html styling and structure update for pdf generation

wceu / camptix-invoices

A WordPress plugin that generates invoices for tickets purchased through Camptix

4 stars 0 forks source link

invoice html styling and structure update for pdf generation #29

Closed nem-c closed 5 years ago

iandunn commented 5 years ago

It looks like there's a few things that PHPCS will report on, like the lack of escaping variables and translated strings.

https://vip.wordpress.com/2014/06/20/the-importance-of-escaping-all-the-things/

https://developer.wordpress.org/plugins/internationalization/security/

avillegasn commented 5 years ago

Thanks @iandunn. Could you point me to the phpcs.ruleset.xml you are using? I'm using the one you mentioned before (https://github.com/WordPress/wordcamp.org/blob/master/phpcs.xml.dist) and it doesn't report anything else. Note that I fixed the code in this pull request in 478bcd94ddcd69b411b60cfca028c66cee696ec7

iandunn commented 5 years ago

Ah, my bad, I missed that you already fixed it in another PR. Thanks!