wch / webshot

Take screenshots of web pages from R
http://wch.github.io/webshot/
227 stars 40 forks source link

mapshot Error refers to webshot: Error in (function (url = NULL, file = "webshot.png", vwidth = 992, vheight = 744, : webshot.js returned failure value: 1 #112

Closed KathaRRRina closed 1 year ago

KathaRRRina commented 2 years ago

Hi there, as I couldn't find a solution with this issue https://github.com/r-spatial/mapview/issues/419, I got the advice to try it here. This is my problem:

I am creating a Report with R Markdown and a part of it is based on maps that I create with leaflet. Then I use mapshot to create a jpg and save the map. So that I can load and show the jpg in the Report.

So far this worked fine, but since my last R update (Version 4.2.0) mapshot creates an Error. And unfortunately I can hardly find any support on this error online. Here is my reproducible example:

´´´ library("leaflet") library("mapview")

m <- leaflet() %>% addTiles() %>% # Add default OpenStreetMap map tiles addMarkers(lng=174.768, lat=-36.852, popup="The birthplace of R") m mapshot(m, file = "C:/Rplot2.jpg") ´´´

This is the Error I get:

´´´ Could not load c:%5CUsers%5CVedi%5CAppData%5CLocal%5CTemp%5CRtmpqcG5qY%5Cfile36844d44770d.html Error in (function (url = NULL, file = "webshot.png", vwidth = 992, vheight = 744, : webshot.js returned failure value: 1 ´´´

I have tried:

The problem occurs on a laptop and on a server I use.

Any help is much appreciated!

wch commented 2 years ago

Does this work?

library(webshot)
webshot("https://www.r-project.org/", "r.png")

I suggest also trying to use webshot for a local HTML file, like this (replacing c:/..../file.html with the path to an actual HTML file on your computer):

webshot("c:/..../file.html", "test.png")

If those work, then the problem is likely to be related to mapshot.

KathaRRRina commented 2 years ago
webshot("c:/..../file.html", "test.png")

Hi wch, thank you for your answer! Your webshot example works for me. Where can I post issues that relate to mapshot? (I am new here)

wch commented 2 years ago

I think the original issue that you filed on the mapview repository is probably a good place to continue.

carlinstarrs commented 2 years ago

I am getting this same error with webshot 0.5.3. Downgrading to 0.5.2 seemed to fix it for some reason. This was all I was trying to run (from the kableExtra package):

mtcars %>%
  kable() %>%
  kable_styling() %>%
  save_kable("test.png")

Both your examples shared above seemed to work with both 0.5.2 and 0.5.3.

Error message:

Could not load c:%5CUsers%5Cusername%5CAppData%5CLocal%5CTemp%5C2%5CRtmp2xUiuR%5Ctest22a032b4e20.html Error in webshot::webshot(file_temp_html, file, ...) : webshot.js returned failure value: 1

c-brendel commented 1 year ago

I am getting this same error with webshot 0.5.3. Downgrading to 0.5.2 seemed to fix it for some reason. This was all I was trying to run (from the kableExtra package):

mtcars %>%
  kable() %>%
  kable_styling() %>%
  save_kable("test.png")

Both your examples shared above seemed to work with both 0.5.2 and 0.5.3.

Error message:

Could not load c:%5CUsers%5Cusername%5CAppData%5CLocal%5CTemp%5C2%5CRtmp2xUiuR%5Ctest22a032b4e20.html Error in webshot::webshot(file_temp_html, file, ...) : webshot.js returned failure value: 1

I'm also saving Leaflet maps to HTML files and had the same error, but downgrading to 0.5.2 also solved the problem for me. I'm using Windows with R version 4.0.3

wch commented 1 year ago

Hm, I think there's a good chance this is due to #110.

wch commented 1 year ago

I just submitted a new version to CRAN with a fix for this issue.

c-brendel commented 1 year ago

I just checked my code again and now it works with webshot 0.5.4! Thanks!