search

wchbrad / vue-easy-tree

A tree component based on vue2.x that supports a small amount of data or a large amount of data, multiple functions, and virtual scrolling.
MIT License
130 stars 40 forks source link

fix https://github.com/wchbrad/vue-easy-tree/issues/6 #11

Closed Zertu closed 2 years ago

Zertu commented 2 years ago

add a new prop item-size so that user can change the height of tree nodes update the versions of babel to version 8 change node-sass to dart-sass

wchbrad commented 2 years ago

Hello, I'm sorry about that this PR failed the local test:

  1. There are omissions in package.json dependencies, you need to add @babel/core
  2. The item-size is not passed to the virtual-tree-node.vue component I'll wait for you about three days If you want to fix these yourselt. If not,I will release this PR with fixes for the above issues.Thanks for your PR
Zertu commented 2 years ago
  1. I have check it on my local PC, I have delete the jsx support in babelrc, and it can run without installing @babel/core
  2. I have add item-size to the tree node component, it has worked!
wchbrad commented 2 years ago

Sorry, I use your https://github.com/Zertu/vue-easy-tree/tree/dev test locally, but after installing with yarn and starting with yarn, the No.2 issue still exists.Here is the screenshot: image

Zertu commented 2 years ago

I have tested with yarn, it really has such issues, but it works well with npm. I have added @babel/core to package.json.

wchbrad commented 2 years ago

OK, the local test has passed, thanks for your contribution, I will merge this PR and make some tweaks, thanks