wcm-io / io.wcm.handler.link

Link resolving, processing and markup generation.
Apache License 2.0
1 stars 2 forks source link

On drag and drop of new component Link Tab title is showing mandatory icon beside title. #16

Closed srigurram7792 closed 3 months ago

srigurram7792 commented 3 months ago

We are using wcm-io/handler/link/components/granite/form/linkRefContainer in our project, if we keep required= true for the link ref node and try to drop new component that contains this linkref.

Expected: validation only done after editor trying to submit the dialog

Actual: The tab title is pre populated with mandatory error icon besides the tab title

CC @stefanseifert

stefanseifert commented 3 months ago

i was not able to reproduce the problem with our sample application, i created a branch which marks the link as required as described in your use case: https://github.com/wcm-io/io.wcm.samples/tree/experimental/make-link-required

then i tried to reproduce the problem with these steps:

it shows * for the required link title and link, but no validation error - this is only shown when trying the save the edit dialog.

srigurram7792 commented 3 months ago

Many thank for the message, Apparently the issue is happening because we use custom link types in the project which in-turn trigger this mandatory check. If I remove this custom link types with the only default link types issue doesn't exist. At least now we are sure that issue doesn't come from wcm.io and we will take it further from here.

stefanseifert commented 3 months ago

thanks for the confirmation!