wcmac / sippycup

SippyCup is a simple semantic parser, written in Python, created purely for didactic purposes.
GNU General Public License v2.0
218 stars 72 forks source link

Remove log-loss option for now #7

Closed cgpotts closed 6 years ago

cgpotts commented 6 years ago

Hi @wcmac – It randomly occurred to me while doing some other implementation work that my addition of a log-loss to learning.py couldn't be correct because the changes were too localized in the code.

I reviewed it just now, and I was right – we'll need to make more extensive changes to support loss='log'. I can't take that up now (I'd want to do a lot of testing), so I'm removing the option for now, so that it doesn't cause anyone problems. I'll return to this in the lead-up to the spring term so that we can support it going forward.

I'll merge this PR so that this error doesn't linger any longer.