wcmc-its / ReCiter

ReCiter: an enterprise open source author disambiguation system for academic institutions
Apache License 2.0
45 stars 24 forks source link

Article Strategy fix #456

Closed sarbajitdutta closed 3 years ago

sarbajitdutta commented 3 years ago

455

454

There was a lookupType attribute introduced in ESearchPmid class which has refreshFlag attributes. For details see https://github.com/wcmc-its/ReCiter-Dynamodb-Model/issues/2

For all articles in ESearchResult only look for articles that have lookupType ALL_PUBLICATIONS and exclude GoldStandardRetrievalStrategy to calculate the count of candidate publications.

This fixes a bug where the articleCount would based on the number of articles in the cluster which was low on incremental name lookup A.K.A ONLY_NEWLY_ADDED_PUBLICATIONS.

sarbajitdutta commented 3 years ago

@paulalbert1 Dont push unless maven central has indexed the latest dependency for dynamodb model. https://search.maven.org/artifact/edu.cornell.weill.reciter/reciter-dynamodb-model which is 2.0.8