search

wcoder / highlightjs-line-numbers.js

Line numbering plugin for Highlight.js
https://wcoder.github.io/highlightjs-line-numbers.js/
MIT License
542 stars 125 forks source link

Fix multiline comments highlighting in c++ #22

Closed rafalk342 closed 6 years ago

rafalk342 commented 6 years ago

I've corrected handling multiline comments in c++. Every tag with a multiline comment is changed into a multiple tags with only one line.

wcoder commented 6 years ago

@rafalk342 Thanks for your help! #21 I will check your solution for other languages.

anlambert commented 6 years ago

For your information, there is a similar issue regarding the highlighting of multi-line strings (for instance, Python ones). See comment in the PR diff for the fix.

wcoder commented 6 years ago

Hi everyone

I investigated this issue #21 and made a common solution.

Please, try it on the separate branch:

https://github.com/wcoder/highlightjs-line-numbers.js/blob/bugfixes/multiline-nodes/src/highlightjs-line-numbers.js

anlambert commented 6 years ago

Hi @wcoder,

I confirm this fixes the encountered issues.

Cheers!

rafalk342 commented 6 years ago

Hello @wcoder, I also confirm that this fixes the issue. Thanks for moving with it forward.

wcoder commented 6 years ago

Thank you for feedbacks and check.

Released new version 2.2 with this fix.