search

wcoder / highlightjs-line-numbers.js

Line numbering plugin for Highlight.js
https://wcoder.github.io/highlightjs-line-numbers.js/
MIT License
541 stars 125 forks source link

Make more modular, support passing hljs to initializer (i.e. prevent needing to bind hljs to window) #77

Open whatl3y opened 4 years ago

whatl3y commented 4 years ago

Is your feature request related to a problem? Please describe. No, simply want to support a more modular approach to initializing this package to prevent having to pollute the window with hljs.

Describe the solution you'd like To be able to pass hljs as a variable in an initializer function/factory/etc. for highlightjs-line-numbers.js to prevent having to bind hljs to the window first.

Describe alternatives you've considered N/A

Additional context N/A

awb99 commented 3 years ago

For me this is a problem. I am trying to use your project, but the way how I require highlight.js is in a way that does not create widow.hljs. Therefore your code fails.

NGPixel commented 1 year ago

I refactored this library for esm, from which you can pass the hljs instance directly:

https://github.com/requarks/highlightjs-line-numbers-esm