wcoder / highlightjs-line-numbers.js

Line numbering plugin for Highlight.js
https://wcoder.github.io/highlightjs-line-numbers.js/
MIT License
541 stars 125 forks source link

`highlight-line-numbers` causing commented code on uncommented code #82

Open azamuddin opened 3 years ago

azamuddin commented 3 years ago

Describe the bug highlight-line-numbers causing commented code on uncommented code

To Reproduce Steps to reproduce the behavior:

  1. I'm developing nextjs app
  2. importing highlight.js lazy loading using NodeJS import()
  3. importing highlightjs-line-numbers.js lazy loading using NodeJS
  4. calling hljs.highlightBlock then hljs.lineNumbersBlock
  5. first render is no problem
  6. if the component did re-render, which also calls again hljs.highlightBlock and hljs.lineNumbersBlock it broke the highlighting

Problem

Expected behavior highlight-line-numbers should not modify highlighting done by highlight.js for the subsequent calls

Screenshots Screen Shot 2021-02-19 at 08 36 20

Desktop (please complete the following information):

Additional context I know I can prevent re-calling the method by tracking if it has been called or not. But I also have cases when this is not possible.