search

wcoder / highlightjs-line-numbers.js

Line numbering plugin for Highlight.js
https://wcoder.github.io/highlightjs-line-numbers.js/
MIT License
541 stars 125 forks source link

Support version(s) is undocumented #88

Closed clach04 closed 2 years ago

clach04 commented 2 years ago

Describe the bug Readme does not document the known working versions of highlightjs.

Implications of this is that it is not clear that highlight.js 11.3.1 does not work with highlightjs-line-numbers.js 2.6.0

From looking at the demo https://wcoder.github.io/highlightjs-line-numbers.js/ it looks like highlightjs-line-numbers.js 2.6.0 works with highlight.js 8.6

Additional context Add any other context about the problem here.

hljs.initHighlightingOnLoad();  // Deprecated as of 10.6.0. initHighlightingOnLoad() deprecated.  Use highlightAll()
clach04 commented 2 years ago

I had a quick play and was able to get current versions as of 2021 to work :)

https://github.com/clach04/highlightjs-line-numbers.js/commit/2563e180a2e48ef0cc147be3e5536d2fcd6bb5f6

highlightjs-line-numbers.js 2.8.0 working with highlight.js 11.3.1

wcoder commented 2 years ago

Docs, samples and demo were updated @clach04 thanks!