wcornwell / earthtones

Derive a Color Palette from a Particular Location on Earth
Other
31 stars 1 forks source link

alternative x=x fix, plus handling {cluster} better #2

Closed mitchest closed 8 years ago

mitchest commented 8 years ago

So, I think a more elegant way of handling the x=x thing, additional to what you've done, is to also remove a default argument binding from get_colors_from_map(). I also wanted to try moving cluster back to Suggests: and try handling it with requireNamespace() - more for my own testing, rather than it actually being important for earthtones haha

codecov-io commented 8 years ago

Current coverage is 45.71% (diff: 0.00%)

Merging #2 into master will not change coverage

@@             master         #2   diff @@
==========================================
  Files             1          1          
  Lines            35         35          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             16         16          
  Misses           19         19          
  Partials          0          0          

Powered by Codecov. Last update cbda43e...908a3d2

mitchest commented 8 years ago

yay, it passed!