Closed mitchest closed 8 years ago
@@ master #2 diff @@
==========================================
Files 1 1
Lines 35 35
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 16 16
Misses 19 19
Partials 0 0
Powered by Codecov. Last update cbda43e...908a3d2
yay, it passed!
So, I think a more elegant way of handling the x=x thing, additional to what you've done, is to also remove a default argument binding from get_colors_from_map(). I also wanted to try moving cluster back to Suggests: and try handling it with requireNamespace() - more for my own testing, rather than it actually being important for earthtones haha