Closed wcrasta closed 2 years ago
wcrasta
commented
2 years ago @richiehu17, I'm going to merge and deploy this code since SOS and Overall Performance currently are broken on the website.
It's not urgent, but if you get the chance, I would appreciate any comments you might have on these changes. Please feel free to comment even though this PR is closed. Thanks!
richiehu17
commented
2 years ago I'll take a look at it tonight or tomorrow night.
I can take a look at just integrating the playoff weeks into the SOS/performance instead of limiting it to the regular season. Not much we can do now, since the API returns slightly different things in the playoffs, so it'd have to be during fantasy playoffs.
I liked the average rank, since if I remember correctly, the calculated season player average ranks would add up to (1+2+...+12)=78. Minimum rank works as well, but the main reason I rewrote the ranking for season averages was because in the below picture, INJ/DTD would represent an 8th place team in the averages for that week instead of a 12th place team, which makes the week to week numbers pretty different and I wanted to standardize it a little.
wcrasta
commented
2 years ago Great! I saw you made another PR so I'll take a look at it and leave any comments I have about the playoffs affecting SOS/performance there.
Regarding the calculation of rankings... I'm not sure I follow this:
> the main reason I rewrote the ranking for season averages was because in the below picture, INJ/DTD would represent an 8th place team in the averages for that week instead of a 12th place team
Using the new calculations (i.e, what I've been referring to as "minimum" rank), INJ/DTD would be 8th place. Are you saying it makes more sense to consider INJ/DTD as 12th rank?
Ignore this. I saw you modified the rankings calculation in #24 as well so I'll leave any questions I have about the calculation there.
KeyError.team_raw['cumulativeScore']did not exist when the week is greater than the current week.max_reg_seasoncode, we should change the code so that it works for both the regular season and the playoffs. I'm not sure what errors will occur during playoffs though.get_ranks()so that multiple players can all have the same rank (the minimum) rather than the average of all the ranks. When I calculated the SOS by hand, using the minimum made things easier to understand imo.