search

wcwhitehead / bootstrap-3-snippets

Bootstrap 3 Snippets for Visual Studio Code
28 stars 45 forks source link

Does not work with files ending with .blade.php #22

Open crzzano opened 7 years ago

crzzano commented 7 years ago

This extension works fine with .html and .php files, just not with laravel blade (.blade.php) files. Don't think it supports Twig either...

ingpedroaraujo commented 7 years ago

Is there any solution for this?

jericopulvera commented 7 years ago

does not work in .php please fix!

parasbansal commented 7 years ago

Any solution?

MaverickMartyn commented 7 years ago

I would like to see this as well. I am pretty sure it worked at one point, but I may be mistaken.

wcwhitehead commented 7 years ago

Added support for .blade

wcwhitehead commented 7 years ago

Reopening. See this thread: https://github.com/wcwhitehead/bootstrap-3-snippets/issues/24

Shoukat-bjr commented 7 years ago

Any solution.....????

wcwhitehead commented 7 years ago

@Shoukat-bjr Nope. As far as I can tell, there isn't a way to conditionally include snippets if a language extension has been installed. If I include support for blade files, users who do not have a blade extension installed will get an error or a warning message.

MaverickMartyn commented 7 years ago

I have seen this done in other extensions, so surely it must be possible.

wcwhitehead commented 7 years ago

@HackerFinn Can you point me to one that does? Remember, it needs to be a snippet extension.

yamenarahman commented 7 years ago

@wcwhitehead bootstrap4 does. https://github.com/thekalinga/bootstrap4-vscode

wcwhitehead commented 7 years ago

@yamenarahman It doesn't look to see if the blade extension is installed and then makes the snippets available -- it just makes it available to blade files. This is what I had originally implemented, but it creates warning messages for anyone who does not have blade support installed.

yamenarahman commented 6 years ago

@wcwhitehead You said you want us to point to a package that works fine and we do, now what will you do to remove this pain ?

strongui commented 6 years ago

Is there any progress on this? I think there should be a setting for this plugin such as emmet: 

"emmet.includeLanguages": {
    "velocity": "html"
  },
mityukov commented 5 years ago

Please just make it available for .blade.php via an option. There, near that option, you can add whatever disclaimer you'd feel appropriate (like: "please make sure you have blade extension installed before enabling this option", etc.)