Adapt EOS WET basis - Githubissues

wcxf / wcxf-bases

Repository for EFT and basis definition files

https://wcxf.github.io/

MIT License

3 stars 9 forks source link

Adapt EOS WET basis #4

Closed dvandyk closed 4 years ago

dvandyk commented 4 years ago

EOS only uses real-valued parameters. To ensure easy usage:

make all WCs real-valued,
for WCs that are treated as complex-valued within EOS, use the correct naming through the 'Re{...}' and 'Im{...}' naming scheme.

This supersedes PR #3.

dvandyk commented 4 years ago

Force-pushed a new commit since I had forgotten to update the JSON file as well.

DavidMStraub commented 4 years ago

LGTM

dvandyk commented 4 years ago

@DavidMStraub can you merge it then? Or has somebody else taken over maintainership of the bases?

DavidMStraub commented 4 years ago

No one has volunteered yet.

Waiting for green light from @jasonaebischerGIT.

dvandyk commented 4 years ago

@DavidMStraub I am only marginally involved in this, but I'd be happy to help out!

jasonaebischerGIT commented 4 years ago

I had a look and it looks good to me too! I can taken over maintainership of the bases, no problem.

dvandyk commented 4 years ago

Good. Since I have no write access, somebody else needs to merge this :-)

dvandyk commented 4 years ago

Thanks Jason!

DavidMStraub commented 4 years ago

Thanks! BTW, the next step is to update the wcxf-bases git submodule in wilson (into which the deprecated wcxf-python module has been merged as of late) to the most recent commit.

dvandyk commented 4 years ago

@DavidMStraub I had already updated my PR for wilson.