Improve exception safety with smart pointers

wdas / SeExpr

SeExpr is an embeddable, arithmetic expression language that enables flexible artistic control and customization in creating computer graphics images. Example uses include procedural geometry synthesis, image synthesis, simulation control, crowd animation, and geometry deformation. https://wdas.github.io/SeExpr

https://www.disneyanimation.com/open-source/seexpr/

Other

406 stars 86 forks source link

Improve exception safety with smart pointers #104

Open elfring opened 4 years ago

elfring commented 4 years ago

Would you like to wrap any pointers with the class template “std::unique_ptr”?

Update candidates:

ExprEditor class
ExprStrSpec::match()

davvid commented 4 years ago

Hmm, Qt object ownership is interesting.

https://doc.qt.io/qt-5/objecttrees.html

In hindsight, the ExprEditor would be better off passing this to the QTimer constructors so that we don't need to do anything in the destructor. unique_ptr wouldn't be appropriate there.

unique_ptr seems like it would be helpful for ExprStrSpec tho.