wdas / SeExpr

SeExpr is an embeddable, arithmetic expression language that enables flexible artistic control and customization in creating computer graphics images. Example uses include procedural geometry synthesis, image synthesis, simulation control, crowd animation, and geometry deformation. https://wdas.github.io/SeExpr
https://www.disneyanimation.com/open-source/seexpr/
Other
405 stars 86 forks source link

Incorrectly duplicated code #107

Closed ikolev21 closed 1 year ago

ikolev21 commented 1 year ago

In src/SeExpr2/UI/ExprCurve.cpp , ExprCurve::openDetail(), lines 432-439 are verbatim copy of lines 423-430.

This looks like a copy-paste bug, I don't see any reason why the block of code within if (dialog->exec() == QDialog::Accepted) should be repeated twice.

davvid commented 1 year ago

Thanks for the heads-up!