search

wdas / SeExpr

SeExpr is an embeddable, arithmetic expression language that enables flexible artistic control and customization in creating computer graphics images. Example uses include procedural geometry synthesis, image synthesis, simulation control, crowd animation, and geometry deformation. https://wdas.github.io/SeExpr
https://www.disneyanimation.com/open-source/seexpr/
Other
405 stars 86 forks source link

Plugin not found prints errors #26

Closed johnburnett closed 9 years ago

johnburnett commented 9 years ago

In SeExprFunc::loadPlugins, if the path being looked at is a directory, and no plugins are found, an error is printed to stderr (line SeExprFunc.cpp:235-238). This feels at odds with "most apps" where they can be pointed to a plugin path that may or may not exist, and have that be treated as a no-op if it doesn't. Would there be any objections to commenting/deleting this bit of printing code?

aselle commented 9 years ago

I have no objections, and I wouldn't mind a patch to that effect. -A

On Thu, Jul 16, 2015 at 2:03 PM, John Burnett notifications@github.com wrote:

In SeExprFunc::loadPlugins, if the path being looked at is a directory, and no plugins are found, an error is printed to stderr (line SeExprFunc.cpp:235-238). This feels at odds with "most apps" where they can be pointed to a plugin path that may or may not exist, and have that be treated as a no-op if it doesn't. Would there be any objections to commenting/deleting this bit of printing code?

— Reply to this email directly or view it on GitHub https://github.com/wdas/SeExpr/issues/26.

johnburnett commented 9 years ago

*just pinging in case you weren't notified of the pull request (I converted this issue into an actual pull request, and I'm not sure how github deals with that).